Issue with client-desync in relation to server-ticking:
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 32/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- java
- Domain
- backend, networking, performance
Research direction
Trace the packet path around the mentioned .executeTick(), .handle, and .genericsFtw entry points, then reproduce the timing behavior with millisecond logging as described. Done means packet handling no longer adds an avoidable tick of latency, with regression coverage or measurements demonstrating the change.
Written by the indexing model from the issue text.
Description
Expected behavior
The expected behavior is so that when the client sends packets, they get processed "immediately", currently what Folia does for every single packet is schedule each packet as a new task, for 1L. If you notice a simple debug, (I have done this) - The time between the packets arrive and get processed should be "instantly" - this is not really a vanilla only thing, but this affects PVP overall and other actions that players would notice a 50ms latency on their action, SPECIALLY if they have a low ping too.
Observed/Actual behavior
Tt really depends on how the player client ticking is also aligned and their ping, while on a paper jar, this won't happen because when the packet arrives it gets processed, the packets are delayed by one tick from when they arrive, and they don't get processed "instantly", they only get processed on the .executeTick() method, this is causing extra delays on actions overall, specially combat in survival.
Steps/models to reproduce
log System Millis of every single packet on the .genericsFtw, and on the ensure same thread that will make the runnable process, observe the behavior of when the .handle method gets called, this will show the latency issue.
I also noticed that the latency of processing of the packets, depends on how fast/ or the timing of in which the regions are created (I am not fully sure if this is because of region creation). - I am able to notice a difference upon restarting it though, sometimes less latency, sometimes high latency.
Plugin and Datapack List
No plugins nor data packets
Folia version
[12:28:35 INFO]: This server is running Folia version git-Folia-"8939611" (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 8939611 on dev/1.20.4)
You are running the latest version
Previous version: git-Folia-"30ee81a" (MC: 1.20.2)
Other
No response
- Dominant language
- Shell
- Stars
- 4.7k
- Forks
- 651
- Avg merge
- 10d 3h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PaperMC/Folia
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
status: needs triage type: bug
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
status: needs triage type: performance
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
status: needs triage type: bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
status: needs triage type: bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Similar issues
-
cicd
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nolte/kamerplanter-appliance#53 ·
Maintainers usually reply within 1 day
-
area:scripts priority:P2 status:backlog
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KD5UJC-XYZ/scarab#1170 ·
Maintainers usually reply within 1 day
-
SETUP: nothing verifies the decider code was ever set, so a skipped step leaves approvals token-onlyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
mattabate/life-distributable#229 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
-
bug fixed good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
sdetweil/MagicMirror-backup-restore#20 · 1 comment ·