启动脚本和崩溃分析硬编码 `.bat`

Open
#3,861 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, shell
Domain
desktop, devtools

Research direction

Five call sites hard-code .bat scripts: CrashReportExporter.cs (lines 16 and 116), CrashLogCollector.cs line 75, WatcherCrash.cs line 39, PageInstanceOverallViewModel.cs line 452, plus the *.bat file filter in zh-CN.axaml line 1025. Start by reading the ILaunchScriptService interface and find where it is defined and registered, then replace each literal with a call through it. Done means no hard-coded .bat remains in these files, the file-picker filter reflects the service's script types, and the project still builds.

Written by the indexing model from the issue text.

Description

  • PCL.Launcher/UI/Crash/CrashReportExporter.cs:16、:116
  • PCL.Launcher.Core/Minecraft/CrashAnalysis/Logs/CrashLogCollector.cs:75
  • PCL.Launcher.Core/Minecraft/Watcher/WatcherCrash.cs:39
  • PCL.Launcher/ViewModels/Instance/PageInstanceOverallViewModel.cs:452
  • PCL.Localization/Languages/zh-CN.axaml:1025 的过滤器仍是 *.bat

接入 ILaunchScriptService。

Dominant language
C#
Stars
4.3k
Forks
148
Avg merge
1d 6h
Merged PRs (30d)
64

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PCL-Community/PCL-CE

All issues in PCL-Community/PCL-CE

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.