启动脚本和崩溃分析硬编码 `.bat`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Five call sites hard-code .bat scripts: CrashReportExporter.cs (lines 16 and 116), CrashLogCollector.cs line 75, WatcherCrash.cs line 39, PageInstanceOverallViewModel.cs line 452, plus the *.bat file filter in zh-CN.axaml line 1025. Start by reading the ILaunchScriptService interface and find where it is defined and registered, then replace each literal with a call through it. Done means no hard-coded .bat remains in these files, the file-picker filter reflects the service's script types, and the project still builds.
Written by the indexing model from the issue text.
Description
PCL.Launcher/UI/Crash/CrashReportExporter.cs:16、:116PCL.Launcher.Core/Minecraft/CrashAnalysis/Logs/CrashLogCollector.cs:75PCL.Launcher.Core/Minecraft/Watcher/WatcherCrash.cs:39PCL.Launcher/ViewModels/Instance/PageInstanceOverallViewModel.cs:452PCL.Localization/Languages/zh-CN.axaml:1025的过滤器仍是 *.bat
接入 ILaunchScriptService。
- Dominant language
- C#
- Stars
- 4.3k
- Forks
- 148
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 64
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PCL-Community/PCL-CE
-
崩溃日志只按 CRLF 分行Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PCL-Community/PCL-CE#3872 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
PCL-Community/PCL-CE#3871 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PCL-Community/PCL-CE#3867 ·
Maintainers usually reply within 1 day
-
[i18n] 安装实例完成后的成功提示未正确本地化Possibly taken @Lokins577 claimed this 35 days ago. Open👍 优质 🚧 正在处理
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
PCL-Community/PCL-CE#3658 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PCL-Community/PCL-CE#3447 ·
Maintainers usually reply within 1 day
All issues in PCL-Community/PCL-CE
Similar issues
-
hand-to-AI
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CactuseSecurity/firewall-orchestrator#5803 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days
-
bug python
Difficulty 1/5 Under an hour Newbie friendliness 88/100
ilia-sokolov/OfficeAgent.NET#89 ·
Maintainers usually reply within 13 days