Attributes repeated in printer-attributes group

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
backend

Research direction

Start by tracing the Get-Printer-Attributes response for the reported HP LaserJet 1320, using the attached bad-attributes.bin.gz dump and the IPP attribute generation entry points in the repository. Check why printer-device-id and printer-strings-languages-supported are emitted repeatedly and why orientation-requested-default is 7; done means the response contains each attribute once and the orientation value matches the supported enum.

Written by the indexing model from the issue text.

Description

I'm using the hplip-printer-app snap version 3.22.10-1 (rev 800) on Ubuntu. I've set it up with a HP LaserJet 1320.

The attributes returned from Get-Printer-Attributes look wrong. Some attributes are present multiple times (printer-device-id is present twice, printer-strings-languages-supported is present 10 or 11 times) and one attribute has an unexpected enum value (orientation-requested-default has value 7, but the enum only defined values 3, 4, 5 and 6).

Here is the relevent ipptool output:

$ cups.ipptool -t ipp://sinister.local:8002/ipp/print/LJ1320 get-printer-attributes-suite.test
"/snap/cups/980/share/cups/ipptool/get-printer-attributes-suite.test":
    Get-Printer-Attributes (no requested-attributes)                     [FAIL]
        RECEIVED: 15800 bytes in response
        status-code = successful-ok (successful-ok)
        Duplicate "printer-device-id" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        Duplicate "printer-strings-languages-supported" attribute in printer-attributes-tag group
        EXPECTED: orientation-requested-default WITH-VALUE "3,4,5,6"
        GOT: orientation-requested-default=7

Here is a dump of the response:
bad-attributes.bin.gz

Dominant language
C
Stars
70
Forks
25
Avg merge
9h 18m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenPrinting/hplip-printer-app

All issues in OpenPrinting/hplip-printer-app

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.