Remove SceneObject::getBinding() functions which don't fetch output for the binding
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
Research direction
Start by locating SceneObject::getBinding() declarations and implementations, then inspect TestSceneObject.cc and search the repository for calls to the legacy overloads. Update the test to use the new functions and remove remaining legacy calls and definitions. Done when no legacy calls remain and the project builds with the new API.
Written by the indexing model from the issue text.
Description
Remove support for the legacy SceneObject::getBinding() functions which don't know about output and update TestSceneObject.cc to use the new getBinding() functions. This should also include a thorough search for any remaining calls to the legacy getBinding() functions.
- Dominant language
- CMake
- Stars
- 4.7k
- Forks
- 321
- Avg merge
- 13m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenMoonRay/openmoonray
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenMoonRay/openmoonray#332 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OpenMoonRay/openmoonray#233 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 57/100
OpenMoonRay/openmoonray#331 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
OpenMoonRay/openmoonray#330 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
OpenMoonRay/openmoonray#329 ·
All issues in OpenMoonRay/openmoonray
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
NethermindEth/nethermind#15684 ·
Maintainers usually reply within 1 day
-
bug(bufdelete): all()/other() abort with "Invalid buffer id" when a buffer is wiped during the loopOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
folke/snacks.nvim#2986 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OCA/l10n-brazil#5602 ·
Maintainers usually reply within 1 day
-
documentation review-2.0.0
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
dkuenzel/meshcore-home-gateway#98 ·
Maintainers usually reply within 1 day
-
mp4box.js — 20-byte `sgpd` box with large `entry_count` causes unbounded loop and heap OOM abortOpen
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day