Follow-ups left open by the Kestrel 80 MHz review (#494)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- c
- Domain
- networking
Research direction
Start with HalKestrel::mac_set_bw_txsc, its caller fast_set_primary_80, and fast_retune; compare logging levels for the per-hop messages. For the register follow-up, inspect vendor mac_set_bw and the corresponding register writes under src/kestrel/, then choose whether to implement it or document the deliberate omission in src/kestrel/CLAUDE.md. Done means same-block hopping no longer emits excessive info logs and the R_AX_TXRATE_CHK decision is either implemented with responder-rate verification on 5 GHz hardware or documented with a clear rationale.
Written by the indexing model from the issue text.
Description
Two items left open by the review of #494 (merged as 357f045). Neither was blocking; both were verified against the vendor source during review, not measured on hardware.
1. mac_set_bw_txsc logs at info on every same-block hop
HalKestrel::mac_set_bw_txsc emits Kestrel set_channel: pri .. center .. rfmod .. txsc .. at info whenever the width is wide, and fast_set_primary_80 calls it on every hop (the review's hop cell wrote one line per hop). The ~3 ms same-block hop exists for slot-cadence hopping (DEVOURER_HOP_SLOT_MS, 10 ms slots), where that is ~100 flushed stderr lines/s at the demos' default log level. The existing fast_retune logs its per-hop line at debug.
Fix: debug level, or log only from the set_channel call site.
2. The vendor pairs RFMOD + TXSC with R_AX_TXRATE_CHK; devourer never writes it
Vendor mac_set_bw (reference/rtl8852cu/phl/hal_g6/mac/mac_ax/hw.c) writes R_AX_TXRATE_CHK (0xC628, mask 0x13) in the same step as R_AX_WMAC_RFMOD and R_AX_TX_SUB_CARRIER_VALUE: B_AX_BAND_MODE on 2.4 GHz, B_AX_CHECK_CCK_EN | B_AX_RTS_LIMIT_IN_OFDM6 on 5/6 GHz. Nothing under src/kestrel/ touches that register, on either die. Pre-existing before #494, which ported the other two writes "as rtw89 rtw8852c_set_channel_mac".
No measured failure. The plausible consumer is the MAC-chosen rate of hardware-generated responses (the ACK responder from #489 on 5 GHz, RTS/protection), which is what this register gates. Either port it alongside mac_set_bw_txsc and measure the responder's response rate before/after on 5 GHz, or record in src/kestrel/CLAUDE.md that it is deliberately left at the CMAC-init default and why.
- Dominant language
- C
- Stars
- 56
- Forks
- 29
- Avg merge
- 3h 43m
- Merged PRs (30d)
- 75
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenIPC/devourer
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)Possibly taken @josephnef claimed this today. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 42/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 12/100
OpenIPC/devourer#579 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 12/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in OpenIPC/devourer
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
389ds/389-ds-base#8157 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
coolsnowwolf/lede#14305 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 2 days