feign-form OSGi Export-Package header is incorrect
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- java
- Domain
- build-system
Research direction
Start by inspecting the POM's maven-bundle-plugin configuration and the generated MANIFEST.MF. Consolidate the Export-Package entries as described, then verify that feign.form, feign.form.multipart, and feign.form.util are exported and that FormEncoder is usable in an OSGi environment.
Written by the indexing model from the issue text.
Description
The current POM has the following:
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<configuration>
<instructions>
<Export-Package>feign.form</Export-Package>
<Export-Package>feign.form.multipart</Export-Package>
</instructions>
</configuration>
</plugin>
Unfortunately, Maven Bundle plugin (and the underlying BND library), only process the 'final' Export-Package command. So, the MANIFEST.MF that is generated has the wrong Export-Package:
Export-Package: feign.form.multipart;version="13.16.0";uses:="feign.codec"
By changing it to:
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<configuration>
<instructions>
<Export-Package>feign.form,feign.form.*</Export-Package>
</instructions>
</configuration>
</plugin>
You end up with the correct MANIFEST.MF of:
Export-Package: feign.form;uses:="feign,feign.codec,feign.form.multipart";version="13.16.0",feign.form.multipart;version="13.16.0";uses:="feign .codec",feign.form.util;version="13.16.0"
Without this change, you can't add the FormEncoder to the Feign builder to add support for x-www-data-urlencoded within an OSGi environment, since FormEncoder is not exported.
- Dominant language
- Java
- Stars
- 9.8k
- Forks
- 1.9k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 37
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenFeign/feign
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
JDK 21 on x86_64 causes truncated responses with Feign + HttpClient (content compression related)Open
Difficulty 4/5 3-5 days Newbie friendliness 42/100
Maintainers usually reply within 1 day
-
question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
OpenFeign/feign#3332 · 1 comment ·
Maintainers usually reply within 1 day
-
question
Difficulty 3/5 1-2 days Newbie friendliness 52/100
OpenFeign/feign#3095 · 1 comment ·
Maintainers usually reply within 1 day
-
bug question
Difficulty 5/5 Over a week Newbie friendliness 25/100
OpenFeign/feign#3074 · 2 comments ·
Maintainers usually reply within 1 day
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
feature triaged
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Graylog2/graylog2-server#27549 ·
Maintainers usually reply within 1 day
-
component/zeebe kind/bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
UniversalMediaServer/UniversalMediaServer#6356 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
googleapis/google-cloud-java#14533 ·
Maintainers usually reply within 1 day