Grib_pi: File correction

Open Beginner friendly
#4,771 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
80/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
c
Domain
tooling

Research direction

Confirm that plugins/grib_pi/src/version.h is not included or referenced anywhere in the codebase. Verify that plugins/grib_pi/src/grib_pi.h contains the active version definition for the grib_pi plugin. Remove the obsolete version.h file and build the project to ensure nothing breaks.

Written by the indexing model from the issue text.

Description

Grib plugin version is listed here, but I think that is an old file
https://github.com/OpenCPN/OpenCPN/blob/master/plugins/grib_pi/src/version.h

Grib_pi actually uses
https://github.com/OpenCPN/OpenCPN/blob/master/plugins/grib_pi/src/grib_pi.h

Grib_pi.h lists the version that I think is actually used:

If so, I think that version.h should be removed.

Dominant language
C
Stars
1.5k
Forks
627
Avg merge
1d 9m
Merged PRs (30d)
9

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenCPN/OpenCPN

All issues in OpenCPN/OpenCPN

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.