[BUG][C#] Generic host loses object oneOf values during serialization
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #25549 by @AndreyVMarkelov — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
Research direction
Reproduce with the generation command and the spec in the issue, then deserialize {"name":"a","size":2} to Entry using the JsonSerializerOptions from the generated HostConfiguration and serialize it back. Linked pull request #25549 is already open against this bug, so review it before starting. Done means the round trip keeps name and size and the output is no longer {}.
Written by the indexing model from the issue text.
Description
Bug Report Checklist
- Have you provided a full/minimal spec to reproduce the issue?
- Have you validated the input using an OpenAPI validator?
- Have you tested with the latest master to confirm the issue still exists?
- Have you searched for related issues/PRs?
- What's the actual output vs expected output?
Description
The C# generichost client serializes an object oneOf without a discriminator to {}, losing the selected variant's properties.
openapi-generator version
Reproduced on master 57edb417ea3fb15de7bc523a133c9cc016acab19 (7.28.0-SNAPSHOT).
OpenAPI declaration file content
openapi: 3.0.3
info:
title: oneOf reproduction
version: 1.0.0
paths: {}
components:
schemas:
Entry:
oneOf:
- $ref: '#/components/schemas/FileEntry'
- $ref: '#/components/schemas/FolderEntry'
FileEntry:
type: object
required: [name, size]
properties:
name:
type: string
size:
type: integer
FolderEntry:
type: object
required: [name, id]
properties:
name:
type: string
id:
type: string
Generation Details
java -jar openapi-generator-cli.jar generate -g csharp --library generichost -i spec.yaml -o client --additional-properties=packageName=OneOfRepro
Steps to reproduce
With JsonSerializerOptions configured by generated HostConfiguration, deserialize {"name":"a","size":2} to Entry, then serialize it. Expected: the same object. Actual: {}.
Related issues/PRs
No matching issue found.
Suggest a fix
Write the active object variant's properties when serializing an object oneOf without a discriminator, preserving any properties declared on the wrapper.
- Dominant language
- Java
- Stars
- 26.9k
- Forks
- 7.8k
- Avg merge
- 2d 23m
- Merged PRs (30d)
- 177
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenAPITools/openapi-generator
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OpenAPITools/openapi-generator#25768 ·
Maintainers usually reply within 1 day
-
Enhancement: Feature
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OpenAPITools/openapi-generator#25753 ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] A non-String value in a pattern-constrained attribute raises NoMethodErrorPossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenAPITools/openapi-generator#25724 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] Response#to_hash is advertised and raises when the data is an ArrayPossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenAPITools/openapi-generator#25723 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] A JSON string response raises ApiError because the body is parsed twicePossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenAPITools/openapi-generator#25719 · 1 comment ·
Maintainers usually reply within 1 day
All issues in OpenAPITools/openapi-generator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
eclipse-tradista/tradista#371 ·
Maintainers usually reply within 1 day
-
critical
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mars-sim/mars-sim#2199 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
projeto-ong-amar/projeto-ong-amar-backend#26 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
primefaces/primefaces#15568 ·
Maintainers usually reply within 1 day
-
崩溃日志只按 CRLF 分行Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PCL-Community/PCL-CE#3872 ·
Maintainers usually reply within 1 day