chore: two dead .admin-workspace-content rules in admin.css
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- css
- Domain
- frontend
Research direction
Read the two .admin-workspace-content rules in admin.css and compare them with the unscoped .admin-stats and .admin-credits-status rules in admin-console.css. Check the referenced wrapper in app.html and its absence from admin.html to understand the scope. Done means the dead rules no longer misleadingly appear to govern /admin, while the existing styling remains intentional.
Written by the indexing model from the issue text.
Description
admin.css carries two rules scoped to .admin-workspace-content:
471 .admin-workspace-content .admin-stats{margin:18px 0 22px}
472 .admin-workspace-content .admin-credits-status{margin:0 0 14px}
That wrapper exists in app.html:2144 but was never ported into admin.html, so neither rule matches anything on /admin. They were retyped from styles.css during the console port; the ancestor element did not come with them.
Not a missing-style bug — admin-console.css supplies both unscoped, at different values:
| /app (styles.css, via wrapper) | /admin (admin-console.css, unscoped) | |
|---|---|---|
.admin-stats |
margin:18px 0 22px |
margin:0 0 16px (:2617) |
.admin-credits-status |
margin-top:14px |
margin-top:14px (:3319) |
So the effect is a small vertical-spacing divergence on the site-stats row between the two pages, plus two rules in admin.css that can never fire. Either delete them or port the wrapper — but they should not stay as-is, because they read as governing /admin and do not.
Found while fixing #494 (which corrects a code comment that cited the dead admin.css rule instead of the live admin-console.css one). No overlap with that PR's changes.
🤖 Generated with Claude Code
- Dominant language
- Python
- Stars
- 767
- Forks
- 156
- Avg merge
- 22h 57m
- Merged PRs (30d)
- 84
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Open-Finance-Lab/AgenticTrading
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Open-Finance-Lab/AgenticTrading#663 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Open-Finance-Lab/AgenticTrading#661 ·
Maintainers usually reply within 1 day
-
fix(llm): a non-ASCII execution handoff raises UnicodeEncodeError instead of ExecutionHandoffErrorPossibly taken @subidhkhanal claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Open-Finance-Lab/AgenticTrading#659 ·
Maintainers usually reply within 1 day
-
fix(backtests): an LLM action with trailing whitespace ("buy ") is silently droppedPossibly taken @subidhkhanal claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Open-Finance-Lab/AgenticTrading#658 ·
Maintainers usually reply within 1 day
-
fix(llm): Gemini adapter drops thinking tokens from the output countPossibly taken @subidhkhanal claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Open-Finance-Lab/AgenticTrading#657 ·
Maintainers usually reply within 1 day
All issues in Open-Finance-Lab/AgenticTrading
Similar issues
-
The changelog workflow excludes otelbot but not dependabot, so every Dependabot pull request fails the changelog checkPossibly taken @ocelotl claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
open-telemetry/opentelemetry-python#5825 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cuga-project/cuga-agent#1020 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
microsoft/playwright#43640 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
stac-utils/stac-fastapi-elasticsearch-opensearch#965 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day