Rate-limit 429 body omits references.situations

Open Beginner friendly
#2,138 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

@Gitesg is already working on this.

Since Nov 18, 2026.

  • #2154 by @Gitesg — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
go
Domain
api

Research direction

Start with rate_limit_middleware.go and inspect how it builds the 429 response body, then read models.NewEmptyReferences() and the OpenAPI Reference schema to confirm the required lists. Update the body construction to use the empty references model and check that the response includes all six lists, including situations.

Written by the indexing model from the issue text.

Description

rate_limit_middleware.go builds its 429 body by hand. Its references object has no situations key, but the OpenAPI Reference schema requires all six lists, so a strict client can fail to decode the response.

Building the body from models.NewEmptyReferences() would keep it in step with every other response. Found while reviewing #2123.

Dominant language
Go
Stars
57
Forks
113
Avg merge
5d 10h
Merged PRs (30d)
151

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OneBusAway/maglev

All issues in OneBusAway/maglev

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.