test(store): Prove purge_expired_tokens removes only expired denylist rows

Open Beginner friendly
#684 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
90/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
postgresql, rust
Domain
database, testing

Research direction

Start in crates/store/tests/store_tests.rs and follow the existing denylist test patterns; check docs/threat-model.md for the stated security constraints. Insert one expired and one live denylist row, call purge_expired_tokens, and verify it returns 1 while is_token_denylisted remains true for the live row. Run cargo test -p octo-store with local Postgres available.

Written by the indexing model from the issue text.

Description

area/backend area/testing enhancement good first issue help wanted

Description

purge_expired_tokens is the only cleanup for the token denylist, and its boundary behaviour is not covered.

Requirements and context

  • Where: crates/store/tests/store_tests.rs
  • Security: Follow docs/threat-model.md; no secrets, tokens or personal data in code, logs, tests or commit messages.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b test/store-denylist-prune

Implement changes

  • Insert one expired and one live denylist row.
  • Call purge_expired_tokens and assert the returned count is 1.
  • Assert is_token_denylisted is still true for the live row.

Test and commit

  • Needs a local Postgres (just db-up); cargo test -p octo-store passes.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

test(store): cover denylist pruning

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.