docs(errors): Correct the From<StoreError> mapping table to match the real conversion

Open Beginner friendly
#680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
documentation

Research direction

Read the From<StoreError> for ApiError match in crates/api/src/error.rs and compare its arms with the table in docs/errors.md. Update the table to list the explicit mappings and the fallback to Internal for database, migration, and audit chain variants. The work is done when every table row matches the conversion.

Written by the indexing model from the issue text.

Description

area/backend documentation good first issue help wanted

Description

The From<StoreError> table in docs/errors.md lists StaleSequence (not a store error) and 'Crypto failures', and omits Conflict, NotFound, InvalidMemoId and DuplicateCustomerRef, which error.rs maps explicitly.

Requirements and context

  • Where: docs/errors.md, crates/api/src/error.rs
  • Security: Follow docs/threat-model.md; no secrets, tokens or personal data in code, logs, tests or commit messages.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b docs/errors-store-error-table

Implement changes

  • Rebuild the table from the impl From<StoreError> for ApiError match.
  • Add rows for Conflict, NotFound, InvalidMemoId and DuplicateCustomerRef.
  • Add one row saying all other variants (database, migration, audit chain) become Internal.

Test and commit

  • Compare each row with the match arms in error.rs.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

docs(errors): fix StoreError mapping table

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.