chore(ingest): Eliminate the duplicated testnet USDC issuer constant shared by ingest and payment links

Open Beginner friendly
#678 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
api, backend

Research direction

Read crates/wallet-core/src/asset.rs and check how crates/ingest/src/lib.rs and crates/api/src/routes/payment_links.rs currently define and use USDC_TESTNET_ISSUER. Move the shared constant into the wallet-core asset module and update both callers to use it. Run just fmt-check, just lint, and just test; done means both crates build and the checks pass.

Written by the indexing model from the issue text.

Description

area/backend enhancement good first issue help wanted

Description

USDC_TESTNET_ISSUER is defined separately in crates/ingest/src/lib.rs and crates/api/src/routes/payment_links.rs, with a comment asking humans to keep them equal.

Requirements and context

  • Where: crates/ingest/src/lib.rs, crates/api/src/routes/payment_links.rs, crates/wallet-core/src/asset.rs
  • Security: Follow docs/threat-model.md; no secrets, tokens or personal data in code, logs, tests or commit messages.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b chore/shared-usdc-issuer-constant

Implement changes

  • Move the constant into a crate both already depend on (e.g. octo-wallet-core::asset).
  • Use it in both places and delete the 'keep in sync' comment.
  • Confirm both crates still build.

Test and commit

  • just test passes.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

chore(ingest): share the USDC issuer constant

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.