fix(server): Reject a malformed SHUTDOWN_DRAIN_TIMEOUT_SECS instead of silently using 25 seconds

Open Beginner friendly
#672 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Start in bin/server/src/main.rs and read the Config::from_env parsing for SHUTDOWN_DRAIN_TIMEOUT_SECS; check check_config.rs if it prints the value. Add tests for valid, malformed, and zero values, then run the listed formatting, lint, and test commands. Done means invalid or zero values fail with a message naming the variable, with all checks passing.

Written by the indexing model from the issue text.

Description

area/backend bug good first issue help wanted

Description

SHUTDOWN_DRAIN_TIMEOUT_SECS is parsed with .ok().and_then(parse).unwrap_or(25); a typo changes how long in-flight requests get during deploys without any warning.

Requirements and context

  • Where: bin/server/src/main.rs
  • Security: Follow docs/threat-model.md; no secrets, tokens or personal data in code, logs, tests or commit messages.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b fix/server-shutdown-drain-parsing

Implement changes

  • Parse strictly and bail with a message naming the variable.
  • Require a value >= 1.
  • Update check_config.rs output if it prints this value.

Test and commit

  • Add Config::from_env tests for valid, malformed and zero values.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

fix(server): validate shutdown drain timeout

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.