fix(server): Reject malformed INGEST_INTERVAL_SECS and INGEST_PAGE_LIMIT values at startup

Open Beginner friendly
#671 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Start in bin/server/src/main.rs at the Config::from_env parsing for INGEST_INTERVAL_SECS and INGEST_PAGE_LIMIT, then read the strict parsing helper near line 489 and its tests near line 815. Add or update Config::from_env tests for missing, malformed, zero, and out-of-range values, and run the listed formatting, lint, and test commands. Done means invalid values fail startup with a clear error and valid values still pass.

Written by the indexing model from the issue text.

Description

area/backend bug good first issue help wanted

Description

bin/server/src/main.rs parses INGEST_INTERVAL_SECS and INGEST_PAGE_LIMIT with .parse().ok().unwrap_or(default), so INGEST_INTERVAL_SECS=abc or 0 is silently ignored or produces a busy loop, unlike the strict INGEST_LOCK_RETRY_SECS handling right below.

Requirements and context

  • Where: bin/server/src/main.rs
  • Security: Follow docs/threat-model.md; no secrets, tokens or personal data in code, logs, tests or commit messages.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b fix/server-ingest-config-parsing

Implement changes

  • Parse both variables strictly with a clear anyhow::bail! message.
  • Require interval >= 1 and page limit between 1 and 200.
  • Reuse the existing strict-parse helper at line ~489 if it fits.

Test and commit

  • Add Config::from_env tests for missing, malformed and zero values (see the existing tests near line 815).
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

fix(server): validate ingest interval and page limit

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.