fix(wallet-core): Restore the provision module that the crate root declares but leaves empty
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Read crates/wallet-core/src/lib.rs, docs/non-custodial-flow.md, and the history for crates/wallet-core/src/provision.rs; then search crates and bin for the named callers. Decide from the non-custodial design whether to restore the module or remove its declaration and re-exports, and update affected callers and tests. Done means the crate builds and the requested formatting, lint, and test checks pass without reintroducing server-side seed handling.
Written by the indexing model from the issue text.
Description
Description
crates/wallet-core/src/provision.rs is a zero-byte file, yet lib.rs does pub mod provision; and re-exports import_wallet, provision_wallet and ProvisionedWallet, which therefore do not exist.
Requirements and context
- Where:
crates/wallet-core/src/provision.rs,crates/wallet-core/src/lib.rs - Security:
wallet-coreis the only crate holding key material; do not add server-side seed handling back (seedocs/non-custodial-flow.md). - Testing:
just fmt-check,just lintandjust testmust pass; add or update tests for the change. - Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.
Suggested execution
- Comment on this issue to claim it, then fork the repository and branch from
main. - Branch name:
git checkout -b fix/wallet-core-empty-provision-module
Implement changes
- Check git history (
git log -- crates/wallet-core/src/provision.rs) for the last real version and restore it, or - if the non-custodial cutover intentionally removed it, delete the module and the three re-exports and fix any callers.
- Run
grep -rn 'provision_wallet\|import_wallet' crates binto find callers.
Test and commit
just buildandjust testsucceed.- Run
just fmt,just lintandjust testlocally before pushing (seeCONTRIBUTING.md). - Commit with a conventional message and keep the change small and focused.
Example commit message
fix(wallet-core): resolve empty provision module
Guidelines
- Open the PR against
mainand link it withCloses #<this issue>. - Keep the diff focused on this issue; no unrelated refactors or formatting churn.
- One line per comment, no bloated code; follow patterns already used in the crate.
- Never commit secrets,
.envfiles or real keys; use public test vectors only. - CI (fmt, clippy
-D warnings, tests) must be green before requesting review. - Ask in the issue thread if anything is unclear before starting.
- Dominant language
- Rust
- Stars
- 0
- Forks
- 91
- Avg merge
- 5h 23m
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Octo-Protocol-org/Octo-Protocol
-
area/integration area/testing enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area/integration area/testing enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area/integration area/testing enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area/integration area/testing enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
area/integration area/testing enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Octo-Protocol-org/Octo-Protocol#701 · 1 comment ·
All issues in Octo-Protocol-org/Octo-Protocol
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pbakaus/impeccable#1601 ·
Maintainers usually reply within 1 day
-
RDF/XML writer: a blank node in two lists is left out of the secondPossibly taken @mrnolte claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
phillord/horned-owl#368 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mongodb/kingfisher#588 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug rust
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days