fix(wallet-core): Restore the provision module that the crate root declares but leaves empty

Open
#661 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Read crates/wallet-core/src/lib.rs, docs/non-custodial-flow.md, and the history for crates/wallet-core/src/provision.rs; then search crates and bin for the named callers. Decide from the non-custodial design whether to restore the module or remove its declaration and re-exports, and update affected callers and tests. Done means the crate builds and the requested formatting, lint, and test checks pass without reintroducing server-side seed handling.

Written by the indexing model from the issue text.

Description

area/contract bug good first issue help wanted

Description

crates/wallet-core/src/provision.rs is a zero-byte file, yet lib.rs does pub mod provision; and re-exports import_wallet, provision_wallet and ProvisionedWallet, which therefore do not exist.

Requirements and context

  • Where: crates/wallet-core/src/provision.rs, crates/wallet-core/src/lib.rs
  • Security: wallet-core is the only crate holding key material; do not add server-side seed handling back (see docs/non-custodial-flow.md).
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Update the nearest doc if behaviour changes; otherwise no doc change is needed.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b fix/wallet-core-empty-provision-module

Implement changes

  • Check git history (git log -- crates/wallet-core/src/provision.rs) for the last real version and restore it, or
  • if the non-custodial cutover intentionally removed it, delete the module and the three re-exports and fix any callers.
  • Run grep -rn 'provision_wallet\|import_wallet' crates bin to find callers.

Test and commit

  • just build and just test succeed.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

fix(wallet-core): resolve empty provision module

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Dominant language
Rust
Stars
0
Forks
91
Avg merge
5h 23m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Octo-Protocol-org/Octo-Protocol

All issues in Octo-Protocol-org/Octo-Protocol

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.