P2642: Avoid division by zero
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with paragraph 12.3 on the converting constructor from layout_stride::mapping, then compare the other mapping constructors, including mapping(ext, pad) and its existing precondition. Done means the constructors handle zero extents or padding without division by zero and apply consistent validity checks; no files or tests are named in the issue.
Written by the indexing model from the issue text.
Description
Para 12.3 of the converting constructor from layout_stride::mapping explicitly divides by zero if the leftmost resp. rightmost extent is zero.
This a general issue with other constructors as well, e.g., if padding_value is zero.
The two-parameter constructor mapping(ext, pad) has a precondition that extents_type::index-cast(pad) is greater than zero. Thus, we already check in some cases. We should consider extending these checks to all the cases, so the mappings behave reasonably.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/cpp-proposals-pub
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
ORNL/cpp-proposals-pub#394 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
ORNL/cpp-proposals-pub#393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ORNL/cpp-proposals-pub#297 ·
-
P3242: LWG ReviewOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ORNL/cpp-proposals-pub#484 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ORNL/cpp-proposals-pub#483 · 2 comments ·
All issues in ORNL/cpp-proposals-pub
Similar issues
-
compiler-rt:asan
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
llvm/llvm-project#242921 ·
Maintainers usually reply within 1 day
-
Client codegen: an import repeated in an impl file is emitted twice, and the browser rejects the modulePossibly taken @MalithaPrabhashana claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
jaseci-labs/jac#10756 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
area:interp bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
yidika-lab/yidika#80 ·
Maintainers usually reply within 1 day