P1673: LWG review 2023/10/18
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 28/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- documentation
Research direction
No file or test is named; the issue is a review record for the P1673 proposal. Start by locating the proposal text and the sections for vector norms, vector_abs_sum, vector_idx_abs_max, and matrix Frobenius norm. Done means applying the recorded wording and structural edits through the stated stopping point, with the C++ standard wording reviewed for correctness.
Written by the indexing model from the issue text.
Description
P1673: LWG review 2023/10/18
- Reexamining "
verb_object" rename of Givens functions. swap- Skip to rank 1 updates
vector_sum_of_squares
CT: We repeat Remarks a lot. Should we float this up? No, just leave it.
vector_two_norm
Para 2 mixes math with prose. Parens in the text are confusing and not needed. Rewrite as follows.
The square root of the sum of square of init and the squares of the absolute values of the elements of v.
Note creeps on normative. "Recommended practice" is the text we use, but should be fine as a Note. Change "suggested" to "possible."
Get rid of separate headers for "specified result type" vs. "default result type," generally throughout the norms etc.
For default result type, delete the arrow and "see-below." It's not observable if the implementation wants to spell out the return type.
What if abs-if-needed returns a proxy reference? That's OK, then the function fails to compile; that's what we want here.
vector_abs_sum
Regarding GENERALIZED_SUM, why don't we do that with vector 2 norm?
We probably don't need it here, just math. Also need a math way to say "real-if-needed" and "imag-if-needed." At least, just drop GENERALIZED_SUM and use words and/or math.
I think we could just say "the sum of init and the absolute values of elements in the domain of v", or just use a math formula.
We will come back next time with a formula version of this. If it looks better, we can use it.
2.2 is redundant but harmless. 2.3 suffices.
Remove section headers "specified result type" and "default result type."
Remove arrow and see-below for return type.
vector_idx_abs_max
Cpp17LessThanComparable semantics can't be checked in Mandates. Let U be decltype(...). Mandates declval<U>() < declval<U>() is a valid expression.
"Mandates: declval<T&>() < declval<T&>() is a valid expression" (but references?)
Or just say less-than comparable.
Also more parens in English, replace with math.
How much of using Cpp17LessThanComparable is about semantics rather than syntax? We require that it is a strict weak order, i.e., it can’t be actually mandated.
So, “let T be decltype(...), Mandates: declval<T>() < declval<T>() is a valid expression.
...
Remove the parenthesis in (2.2) -- don't have a precondition -- keep the Mandates. Remove "(in the domain v)."
[linalg.algs.blas1.matfrobnorm]
Same changes as before: “see-below” and removing the subsections.
Stopping before [linalg.algs.blas1.matonenorm].
Stopped after matrix Frobenius norm, before matrix one norm.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/cpp-proposals-pub
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
ORNL/cpp-proposals-pub#394 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
ORNL/cpp-proposals-pub#393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ORNL/cpp-proposals-pub#297 ·
-
P3242: LWG ReviewOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ORNL/cpp-proposals-pub#484 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ORNL/cpp-proposals-pub#483 · 2 comments ·
All issues in ORNL/cpp-proposals-pub
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Netcracker/qubership-ai-packages#266 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
modelcontextprotocol/php-sdk#746 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#5790 ·
Maintainers usually reply within 1 day
-
bot-found documentation priority: P3
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
madenvel/KalinkaPlayer#602 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day