`mdspan`: question about `layout_stride` constructors for `layout_left` and `layout_right`

Open
#402 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
compilers

Research direction

Compare the layout_stride::mapping constructors for layout_left::mapping and layout_right::mapping, then review the change introduced in #181. Determine whether the differing noexcept specification is intentional; done means either confirming the rationale or aligning the constructors if it was a typo.

Written by the indexing model from the issue text.

Description

While reviewing <mdspan> for MSVC STL, @StephanTLavavej noticed that the layout_stride::mapping constructor is noexcept for layout_right::mapping, but not for layout_left::mapping. It appears this happened in #181. They both have similar preconditions, so we're not sure if there's a reason for it that's escaped us, or if it was a typo.

Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ORNL/cpp-proposals-pub

All issues in ORNL/cpp-proposals-pub

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.