P1673R12: Varna 2023 LWG review comments
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- documentation
Research direction
Start by reviewing the P1673R12 wording around the mdspan layout policy requirements and the TODO list in this issue. Then inspect issue 390 for the linked changes, including the exposition-only concepts and wording questions for abs, conj, imag, and real. Done means the listed review items are resolved or explicitly dispositioned.
Written by the indexing model from the issue text.
Description
Varna 2023 LWG review comments
2023/06/14
"your matrix_layout_policy isn’t a layout_policy because the latter needs to support any extent" -- not clear whether this is an action item.
2023/06/15
Change to mdspan's specification, not to P1673?
A possible problematic interpretation of [mdspan.layout.policy.reqmts]. Suggested edit: A type MP meets the layout mapping policy requirements if for a type E that is a specialization of extents such that MP::mapping<E> is valid, MP::mapping<E> denotes a type X that meets the layout mapping requirements ([mdspan.layout.reqmts]), and for which the qualified-id X::layout_type is valid and denotes the type MP and the qualified-id X::extents_type denotes E.
TODO list
- Remove reference to P2642R2. P1673 is orthogonal to P2642.
- Change the exposition-only
is-mdspanto be a variable template. - Change "it will do so in read-only fashion" to "it does so ...."
- Implement changes in https://github.com/ORNL/cpp-proposals-pub/issues/390
- Fix
in-vector(and analogous exposition-only concepts) declaration - Fix "xT"
- Figure out what wording LWG wants for
abs,conj,imag, andreal
- Fix
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/cpp-proposals-pub
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
ORNL/cpp-proposals-pub#394 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
ORNL/cpp-proposals-pub#393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ORNL/cpp-proposals-pub#297 ·
-
P3242: LWG ReviewOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ORNL/cpp-proposals-pub#484 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ORNL/cpp-proposals-pub#483 · 2 comments ·
All issues in ORNL/cpp-proposals-pub
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Netcracker/qubership-ai-packages#266 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
modelcontextprotocol/php-sdk#746 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#5790 ·
Maintainers usually reply within 1 day
-
bot-found documentation priority: P3
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
madenvel/KalinkaPlayer#602 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day