P1673R12: LWG comments from chat
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- documentation
Research direction
Start by reading the sections on abs, conj, imag, and real, P2642R2, exposition-only concepts in [linalg.syn], and wording in [linalg.general]. Resolve the open questions about lookup behavior and whether P2642R2 is needed before applying the specified wording changes. Done means the P1673 wording reflects the agreed LWG guidance.
Written by the indexing model from the issue text.
Description
Varna 2023 LWG comments from chat
Regarding abs, conj, imag, and real
LWG was concerned about the following wording in [linalg.general].
Within all the functions in [linalg], any calls to
abs,conj,imag, andrealare unqualified.
A suggestion was to reuse the wording form used in [contents] p3 at the end, like the following.
Throughout the specification in [linalg], the meanings of the unqualified names
abs,conj,imag, and real are established as-if by performing argument-dependent lookup (6.5.4)."
LWG's impression of the intention is that abs, conj, imag, and real are selected via overload resolution on a candidate set that includes:
- the correspondingly named functions defined in
<cmath>([cmath.syn]), and - the lookup set produced by argument-dependent lookup (6.5.4).
I clarified that the abs / conj / imag / real machinery in P1673 exists for the following reasons.
- For custom types, use ADL to find the functions.
- For custom types, assume that if conj, imag, or real can't be found via ADL, then the type represents a non-complex number.
- For Standard types, "fix" behavior of existing
<cmath>etc. functions (e.g., so that abs of an unsigned integer is the integer, and conj of a real number doesn't have complex type).
P2642R2
LWG was concerned that the wording says "apply all wording from P2642R2," but P2642R2 is still in LEWG review. This wording replaced some mdspan layouts that were originally in the proposal. I think P2642 is completely separable from P1673, so we might not even need this.
Fix declaration form of exposition-only concepts
In [linalg.syn], replace patterns like this:
template<class T>
concept in-vector; = // exposition only
with
template<class T>
concept in-vector = _see below_; // exposition only
Fix [linalg.general]
[linalg.general] (1.2) and (1.3), change
The pattern xT should be read as “the transpose of x.”
to the following (as "should" sounds like implementations could ignore it):
The pattern xT has the meaning “the transpose of x."
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/cpp-proposals-pub
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
ORNL/cpp-proposals-pub#394 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
ORNL/cpp-proposals-pub#393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ORNL/cpp-proposals-pub#297 ·
-
P3242: LWG ReviewOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ORNL/cpp-proposals-pub#484 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ORNL/cpp-proposals-pub#483 · 2 comments ·
All issues in ORNL/cpp-proposals-pub
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Netcracker/qubership-ai-packages#266 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
modelcontextprotocol/php-sdk#746 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#5790 ·
Maintainers usually reply within 1 day
-
bot-found documentation priority: P3
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
madenvel/KalinkaPlayer#602 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day