D2630R4 LWG feedback: 2023/05/31
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- documentation
Research direction
Start by reading Section 3.1 and the cited mdspan.submdspan.overview changes in the proposal. Wait for Jonathan Wakely's suggestion before changing the hidden-friend wording; done means additions are highlighted in green and the agreed declarations no longer use the invalid mapping:: scope.
Written by the indexing model from the issue text.
Description
@crtrott @dalg24
Most recent changes reviewed
Changes that were OK
- [mdspan.submdspan.overview] para 1, OK.
- [mdspan.submdspan.overview] para 2.5, OK, more legible now.
Requested changes
- In Section 3.1, please highlight additions in green (for changes in [contents]).
- For hidden friends, declarations should appear in the class synopses as well (they already do; that declaration is correct). We don't want that
mapping::scope because it's not valid C++. Otherwise, the coalesced wording is fine. We could even just remove themapping::and put each declaration as a friend in its relevant mapping. We can still describe them here. Wait until later; Jonathan Wakely will e-mail us with a suggestion (the template parameters as displayed aren't correct). There may actually be an outstanding LWG issue about wording for hidden friends.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/cpp-proposals-pub
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
ORNL/cpp-proposals-pub#394 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
ORNL/cpp-proposals-pub#393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ORNL/cpp-proposals-pub#297 ·
-
P3242: LWG ReviewOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ORNL/cpp-proposals-pub#484 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ORNL/cpp-proposals-pub#483 · 2 comments ·
All issues in ORNL/cpp-proposals-pub
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Netcracker/qubership-ai-packages#266 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
modelcontextprotocol/php-sdk#746 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#5790 ·
Maintainers usually reply within 1 day
-
bot-found documentation priority: P3
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
madenvel/KalinkaPlayer#602 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day