D2630R4 LWG feedback: 2023/05/31

Open
#384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
documentation

Research direction

Start by reading Section 3.1 and the cited mdspan.submdspan.overview changes in the proposal. Wait for Jonathan Wakely's suggestion before changing the hidden-friend wording; done means additions are highlighted in green and the agreed declarations no longer use the invalid mapping:: scope.

Written by the indexing model from the issue text.

Description

@crtrott @dalg24

Most recent changes reviewed

Changes that were OK

  • [mdspan.submdspan.overview] para 1, OK.
  • [mdspan.submdspan.overview] para 2.5, OK, more legible now.

Requested changes

  • In Section 3.1, please highlight additions in green (for changes in [contents]).
  • For hidden friends, declarations should appear in the class synopses as well (they already do; that declaration is correct). We don't want that mapping:: scope because it's not valid C++. Otherwise, the coalesced wording is fine. We could even just remove the mapping:: and put each declaration as a friend in its relevant mapping. We can still describe them here. Wait until later; Jonathan Wakely will e-mail us with a suggestion (the template parameters as displayed aren't correct). There may actually be an outstanding LWG issue about wording for hidden friends.
Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ORNL/cpp-proposals-pub

All issues in ORNL/cpp-proposals-pub

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.