Support unpreconditioned GMRES

Open
#467 1 comment 1 reaction 1 assignee View on GitHub

@kakeueda is already working on this.

Since Sep 30, 2026.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
hpc

Research direction

Locate the existing Preconditioner interface, GMRES implementation, and handling of precond = "none"; then inspect how current preconditioners are selected and applied. Implement support using the existing interface as described, and verify that unpreconditioned GMRES runs successfully and can provide a baseline for preconditioned runs.

Written by the indexing model from the issue text.

Description

enhancement iterative solver
Summary

Add support for unpreconditioned GMRES when precond = "none".

Rationale

Unpreconditioned GMRES provides a useful baseline for evaluating new preconditioners, including improvements in iteration count and total runtime with setup costs included. It also helps with debugging by narrowing down the source of failures through preconditioned and unpreconditioned runs.

Description

A minimal implementation would be to add PreconditionerIdentity, a class derived from Preconditioner that represents $M = I$ and is therefore mathematically equivalent to applying no preconditioner. This approach would simply reuse the existing preconditioner interface and GMRES implementation with minimal changes.

Alternatively, GMRES could provide a dedicated unpreconditioned path that does not use $M$ at all, but this would require more changes.

Additional information

No response

Dominant language
C++
Stars
85
Forks
14
PR merge metrics
No merged PRs in 30d

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ORNL/ReSolve

All issues in ORNL/ReSolve

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.