Support unpreconditioned GMRES
@kakeueda is already working on this.
Since Sep 30, 2026.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Locate the existing Preconditioner interface, GMRES implementation, and handling of precond = "none"; then inspect how current preconditioners are selected and applied. Implement support using the existing interface as described, and verify that unpreconditioned GMRES runs successfully and can provide a baseline for preconditioned runs.
Written by the indexing model from the issue text.
Description
Summary
Add support for unpreconditioned GMRES when precond = "none".
Rationale
Unpreconditioned GMRES provides a useful baseline for evaluating new preconditioners, including improvements in iteration count and total runtime with setup costs included. It also helps with debugging by narrowing down the source of failures through preconditioned and unpreconditioned runs.
Description
A minimal implementation would be to add PreconditionerIdentity, a class derived from Preconditioner that represents $M = I$ and is therefore mathematically equivalent to applying no preconditioner. This approach would simply reuse the existing preconditioner interface and GMRES implementation with minimal changes.
Alternatively, GMRES could provide a dedicated unpreconditioned path that does not use $M$ at all, but this would require more changes.
Additional information
No response
- Dominant language
- C++
- Stars
- 85
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/ReSolve
-
SystemSolver still uses string to select configuration optionsMay be free again A pull request for this issue was closed without being merged. Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Support P and Q permutations provided by the user in `LinSolverDirectKLU`May be free again @stark256-spec claimed this 39 days ago, and no pull request is open. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
enhancement question
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day