OHDSI/gaiaCore

loadGeometry() will not work if an empty table of same name exists

Open

#15 opened on Nov 10, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (3 forks)auto 404
good first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

Line 35 loadGeometry.R checks if table exists. If exists, doesnt load table.

This is almost always ideal, except in the rare case that a table starts to load, fails, and an empty table is left in database.

maybe loadGeometry() needs an overwrite flag?

I think a better and easier solution is to add a simple "if table exists AND table has more than zero rows" logic to loadgeometry.

Contributor guide

Research direction
Investigate the loadGeometry() function in loadGeometry.R. The current code checks if the table exists and skips loading if it does. The issue suggests adding a check for non empty table. Look at the code around line 35 to understand the table existence check. Consider implementing a condition that also checks if the table has rows using a query like 'SELECT COUNT(*)' from the table. Alternatively, add an overwrite parameter to force loading even if table exists. Choose the simpler approach: modify the if statement to include a row count check. Test with an empty table scenario.
Tech stack
rjava
Domain
database
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80