OHDSI/DatabaseConnector

Download drivers `method` argument

Open

#206 opened on Oct 16, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)R (91 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (57 stars)
PR merge metrics
 (PR metrics pending)

Description

The function for downloading drivers downloadJdbcDrivers has an argument method which is then passed to utils::download.file per the documentation here:

https://github.com/OHDSI/DatabaseConnector/blob/6bdece864cfa9a5c9ea9b6d5473df4d2f8a30335/R/Drivers.R#L36

Looking at the documentation for utils::download.file, the method argument will assume a default value of auto but it can be overridden using options(download.file.method = "auto").

So I'd propose we remove the method argument since it prevents users from controlling the behavior of utils::download.file using options and instead we can just note this in the description of the function or link to the utils documentaiton.

Contributor guide

Research direction
Remove the `method` argument from the `downloadJdbcDrivers` function signature and update the function body to use `options` for download method. Update documentation accordingly.
Tech stack
r
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
R
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70