[18.0] mail_send_confirmation external-recipient warning appears when replying in Discuss
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start with mail_send_confirmation/static/src/models/composer_view.esm.js and read the Composer.sendMessage() condition; compare it with the composer behavior in Odoo’s addons/mail/static/src/core/common/composer.js. Reproduce the reply in Discuss and confirm the distinction from chatter messages. Done means internal Discuss replies send without the external-recipient warning, while chatter messages that may reach external followers still show it.
Written by the indexing model from the issue text.
Description
Module
mail_send_confirmation (18.0.1.0.0)
Describe the bug
When replying to a previous message in the Discuss app, the composer displays the confirmation dialog warning that the message will be sent to external partners when the user is replying within Discuss and not sending a chatter message to external followers.
The issue only happens in the Discuss app, not the discuss menú that's on the top right.
To Reproduce
Affected versions: Odoo 18.0 with mail_send_confirmation 18.0.1.0.0.
Steps to reproduce the behavior:
- Open the Discuss app and enter the a conversation.
- Use the Reply action on an earlier message from another participant.
- Write a reply and send it.
- Observe the confirmation dialog saying the message will be sent to external partners.
Current behavior: The external-recipient confirmation appears for the Discuss reply.
Expected behavior: An internal Discuss reply should send without the external-recipient warning. The confirmation should still appear when sending a chatter message that may reach external followers.
Additional context
The module patches Composer.sendMessage() and opens the dialog whenever this.props.type === "message". That condition does not distinguish a record’s chatter from a Discuss conversation (discuss.channel), so it appears too broad for this case:
https://github.com/OCA/mail/blob/18.0/mail_send_confirmation/static/src/models/composer_view.esm.js
Odoo’s composer uses messageToReplyTo for replies and posts Discuss messages to discuss.channel:
https://github.com/odoo/odoo/blob/18.0/addons/mail/static/src/core/common/composer.js
A possible fix is to limit this confirmation to the intended chatter context, excluding internal Discuss channel messages.
- Dominant language
- Python
- Stars
- 36
- Forks
- 180
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 14
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OCA/mail
-
[18.0] mail_drop_target: uploading a file to a Discuss channel fails (_get_as_sudo_from_request_or_raise no longer exists)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Activity creation without model_idPossibly taken @parabol123654 claimed this 4 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
Maintainers usually reply within 1 day
Similar issues
-
add entry to blockOpen
Difficulty 1/5 Under an hour Newbie friendliness 65/100
StevenBlack/hosts#3299 ·
-
`garak --report` overwrites the input report when its name has no ".report"Possibly taken @0z5a claimed this today. Openneeds-triage
Difficulty 2/5 Half a day Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
plot_graph crashes when a mesh node has no m2m edgePossibly taken @tygvi claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
mllam/neural-lam#883 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
future-agi/future-agi#4092 · 1 comment ·
Maintainers usually reply within 1 day
-
transcript analytics: a text whose only protected spans the prose pass redacts is withheld wholeOpen
Difficulty 1/5 Under an hour Newbie friendliness 82/100
WingedGuardian/GENesis-AGI#4641 ·
Maintainers usually reply within 1 day