Diagnostics never carry DiagnosticTag.Unnecessary: unused opens and dead code are not greyed out
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- fsharp
- Domain
- devtools
Research direction
Start by reading the sidecar diagnostic wire type and the host's LSP conversion, which the issue identifies as lacking tag support. Trace how unused, unreachable, and obsolete findings reach that conversion; done means the corresponding diagnostics carry the specified Unnecessary or Deprecated tags.
Written by the indexing model from the issue text.
Description
What happens
No diagnostic SharpLsp publishes carries a DiagnosticTag. VS Code therefore never greys out unused code: an unused open (SLSPF0102, published as a Hint), dead code (SLSPC0101, SLSPF0101) and Roslyn's unused-variable hints all render as ordinary text. Hint-severity findings stay invisible apart from three small dots.
The analyzer's own comment says the hints are surfaced "so the editor can grey them out" (FSharpAnalyzers.unusedOpenDiagnostics). Neither the sidecar wire type nor the host's LSP conversion has a field for tags.
Expected
Unused and unreachable findings carry DiagnosticTag.Unnecessary (1), and obsolete-symbol findings carry DiagnosticTag.Deprecated (2), as FSAC and Roslyn LSP do.
Found while filming the Diagnostics docs page.
- Dominant language
- TypeScript
- Stars
- 168
- Forks
- 9
- Avg merge
- 2h 51m
- Merged PRs (30d)
- 59
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Nimblesite/SharpLsp
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Nimblesite/SharpLsp#468 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Nimblesite/SharpLsp#461 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Nimblesite/SharpLsp#447 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Nimblesite/SharpLsp#444 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Nimblesite/SharpLsp#442 ·
Maintainers usually reply within 1 day
All issues in Nimblesite/SharpLsp
Similar issues
-
bug require-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
expressjs/expressjs.com#2549 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
umami-software/umami#4686 · 1 comment ·
Maintainers usually reply within 2 days
-
[Bug]: Device screenshot fails with 500 on iPhone Duo (Xcode 27.2): serve-sim calls simctl without --displayPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
pingdotgg/t3code#24900 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inu-appcenter/UNIDorm-web#411 ·
Maintainers usually reply within 1 day
-
🐛 bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days