[Engine] qsa_rows_bench: --ctx below 32768 makes the dense step read outside the page table (Xid 31)
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Read src/kernels/qsa_rows_bench.cpp around lines 138 and 207 to trace how the dense window width and cell ids are built. Reproduce with qsa_rows_bench --rows --iters 100 --ctx 16384 --max-context 262144; verify the fix keeps the dense step within the context and that the 16K run completes without an illegal memory access.
Written by the indexing model from the issue text.
Description
Problem. qsa_rows_bench with a context under 32768 cells faults on the GPU. The dense step's window is fixed at
32768 cells, so at a shorter context its cell ids start below 0, and nothing bounds them.
Repro (RTX 5080, sm_120, driver 615.71.09, CUDA 13.3, Release build of the qsa_rows_bench target; the bench file is
identical to main):
qsa_rows_bench --rows --iters 100 --ctx 16384 --max-context 262144
Output, exit code 2:
qsa_rows_bench on device 0 (NVIDIA GeForce RTX 5080, 12.0), 100 iterations: context 16384, capacity 262144 cells (max_blocks 65538), selection cap 2051, int8 pools over 16452 cells
selections: width 2051 a row; union of 2 rows 2360 cells (1.15x one row) union of 3 rows 2541 cells (1.24x one row) union of 4 rows 2608 cells (1.27x one row)
qsa_rows_bench: warm: an illegal memory access was encountered
Kernel log at the same moment:
NVRM: Xid (PCI:0000:01:00): 31, name=qsa_rows_bench, intr 00000000. MMU Fault: ENGINE GRAPHICS GPC6 GPCCLIENT_T1_5 faulted @ 0x220_cddf1000. Fault is of type FAULT_PDE ACCESS_TYPE_VIRT_READ
Cause (unconfirmed static analysis):
src/kernels/qsa_rows_bench.cpp:207fills the dense window's ids asctx + t + 1 - dense_win + j, with
dense_win = 32768(line 138).- At
--ctx 16384the first 16383 ids of each row are negative. - The batched decode attention reads
p.page_table[cell / page_size](src/kernels/cuda/qsa_decode_attn.cu:206, and
418 and 618 in the other variants) with no lower bound, so the read lands before the page table. - The engine never passes negative ids, so the kernel itself is fine. The missing bounds check is in the bench.
- The default
--ctx 131072and any context of 32768 or more stay in range.
Suggested fix: clamp the dense window to the context (min(dense_win, ctx + t + 1) cells a row, with the step
record's width to match), or skip the dense step when ctx + 1 < dense_win.
Validation:
- Run: the 16K case above, once (it faulted).
- Not run: 64K / 131K / 200K,
--no-denseat 16K, and any fix. We will not run the bench again until it is fixed.
Measured and drafted with Claude Code.
- Dominant language
- C++
- Stars
- 11.6k
- Forks
- 1k
- Avg merge
- 18d 13h
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Niko1221/Strata
-
needs-format
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Niko1221/Strata#6251 · 1 comment ·
Maintainers usually reply within 5 days
-
[TUI] A leftover run config marks a model installed: the list checks the file name, not the filesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 5 days
-
needs-format
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Niko1221/Strata#6229 · 1 comment ·
Maintainers usually reply within 5 days
-
[Engine] explicit --layer-split reloads CUDA0 dense weights a second time at startup (0 MiB freed)Possibly taken @wronglebowsk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 5 days
-
[Other] Terminal: shell tab completion for the strata commandPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Niko1221/Strata#6086 · 2 comments ·
Maintainers usually reply within 5 days
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
metasequoiaime/msime#11666 ·
Maintainers usually reply within 1 day
-
DAE2 crashes on call.without.effects with a non ref.func expressionPossibly taken @stevenfontanella claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
WebAssembly/binaryen#9404 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
CodeZombie/goodluckOS#178 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
CVO-Org/immersive-cigs-rewrite#313 ·
Maintainers usually reply within 1 day
-
windows-latest (20261116.315.1) ships with incompatible MSVC (18.12) and pinned LLVM/Clang (20)Openbug report
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
actions/runner-images#15367 · 4 comments ·
Maintainers usually reply within 2 days