[Other] tools/test_strata_mcp.py: unittest.main() sits before the last three test classes, so a direct run skips 7 tests
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
Open tools/test_strata_mcp.py and find the if __name__ == "__main__": block with unittest.main() near line 937, which sits before the classes RemoveMissingFilesTest, DiskUsageTest and DraftLayerAndCancel. Move that guard to the end of the file so every class is defined before it runs. Done when python tools/test_strata_mcp.py reports 52 tests, matching python -m unittest tools.test_strata_mcp. The one failure from the Mac DeepSeek check belongs to #4904 and is outside this fix.
Written by the indexing model from the issue text.
Description
tools/test_strata_mcp.py ends its run early when it is executed directly: its if __name__ == "__main__": unittest.main() block sits at line 937 of 1112, before the last three test classes. unittest.main() collects the
classes defined at that point, so the classes appended after it never run.
Reproduce
$ python tools/test_strata_mcp.py
Ran 45 tests in 68.455s
FAILED (failures=1) # the Mac DeepSeek check, a separate issue (#4904)
$ python -m unittest tools.test_strata_mcp
Ran 52 tests in ... # the same 45 plus the 7 below
The 7 tests in RemoveMissingFilesTest, DiskUsageTest and DraftLayerAndCancel are skipped by the direct run,
silently, with no warning. They are in the file's own sections ("Deleting a model whose plan lists files that are
already gone…", "Storage showed IQ3_S as 0.0 GB…", draft-layer progress), so a person running the file the way the
other tools/test_*.py files are run does not see them pass or fail.
The classes came in later commits (917d2fc3, 31030b17) appended at the end of the file, after the guard that
was already in the middle.
Expected
Every test in the file runs in a direct run as well, like the other tools/test_strata_mcp.py classes.
- Dominant language
- C++
- Stars
- 11.6k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Niko1221/Strata
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 3 days
-
[Benchmark] Tesla T4 (sm_75): kIlRows_75 gives +12% on a T4; MMVQ_IL_TABLE.md says sm_75 is offOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
-
[Other] tools/test_strata_mcp.py: the Mac DeepSeek list test fails on main (it still expects the two IST-DAS sets)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 3 days
-
[Engine] "Download and prepare" asks for the full 128 GB on an installed NVFP4 pack: the disk check looks in models\<family-tag><model> while setup writes models\<owner>--<repo>Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Niko1221/Strata#4892 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
Similar issues
-
Issue-Bug Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/winget-cli#6645 ·
Maintainers usually reply within 2 days
-
cleanup help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ESPresense/ESPresense#2602 ·
Maintainers usually reply within 1 day
-
devex good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
artifact:simulation-scenario domain:physics good first issue help wanted role:validation testing
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
[BUG] `mx.qqmm` docs: the Args section names `global_scale`, but the parameter is `global_scale_x`Possibly taken @Redempt1onzzZZ claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
ml-explore/mlx#4815 ·
Maintainers usually reply within 2 days