[TUI] strata launch --stop prints "Nothing is running" right after a failed stop — and always exits 0
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
The bug is in the --stop handling in strata_cli/launch/cmd.py around lines 499-506: stopped counts only successful stops, so a failed stop falls into the elif not stopped: branch, which prints the same message as the no-targets case, and the function ends with an unconditional return 0. Start by reading that block and the code that calls runtime.stop, then find the test or harness that covers --stop. Done means a failed stop reports its error without also saying nothing is running, and the exit-code behaviour is decided and tested, since the issue leaves that choice to the maintainer.
Written by the indexing model from the issue text.
Description
Problem: strata_cli/launch/cmd.py:499-506. stopped counts only SUCCESSFUL stops, so a failed stop lands in elif not stopped: — which prints the SAME sentence as the no-targets branch: the two branches are literally the same statement. A failed stop therefore reads "Could not stop office: ." followed by "Nothing from strata launch is running." And return 0 is unconditional: exit 0 whether something stopped, nothing ran, or a stop FAILED.
Environment:
Strata Version: 0.2.7 (source checkout at tag v0.2.7, commit 5e8a4cca; the file discussed is byte-identical to the tag)
OS: Linux x86-64
Runtime: Python 3.14
Reported from the Strata-Mnemosyne fork's merged tree; the offending code is upstream's own.
Reproduce (measured): with runtime.status → ready and runtime.stop → {ok: False, error: leftover_process_not_ended}, --stop printed:
Could not stop office: leftover_process_not_ended.
Nothing from `strata launch` is running.
return code: 0
Expected: no contradiction; a failed stop should not read as "nothing is running", and scripts/agents gating on the exit code should not proceed to re-launch onto a port the leftover engine still holds (they then eat the check_port_free refusal). Whether the exit code should turn nonzero on a failed stop is your call — the identical-branch message looks unintended either way.
Reproduction status: measured at function level.
- Dominant language
- C++
- Stars
- 11.6k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Niko1221/Strata
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Niko1221/Strata#4630 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Niko1221/Strata#4589 · 1 comment ·
Maintainers usually reply within 3 days
-
[Engine] strata-sycl.sh drops every STRATA_* variable whose value is 0, so the documented STRATA_PREFILL_MMQ=0 (FP16 prompt path) never reaches the engine; "off" works by accidentPossibly taken @ctr-137 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 3 days
-
[Other] tools/ab_engine.py reuses ab_<arm>_r<n>.log in the temp dir across runs, so a later A/B appends its engine logs to an earlier onePossibly taken @ctr-137 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 3 days
Similar issues
-
good first issue invalid
Difficulty 1/5 Under an hour Newbie friendliness 72/100
DanielJerolm/gpcc#74 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
patrick-hudson/put.gd-desktop#808 ·
Maintainers usually reply within 1 day
-
DPI change is not fully handled in the cascading window on WindowsPossibly taken @yukawa claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 4 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
enhancement Ready for final check
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
mpogue2/SquareDesk#1818 · 1 comment ·