Sinker Side Burn: electrode wear compensation

Open
  • Is something wrong?
#1,340 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Start by reading motion::sinker_wear and the sinker_side application tests, then trace the by-name refusals in create, edit, paste, change-kind, the project reader, and the generator. The design must settle whether side wear affects the allowance. Done means compensated plunge and lateral moves stay above the deepest compensated tip, the stock simulation finds a clean cavity, the refusal is removed, and motion and app tests cover these cases.

Written by the indexing model from the issue text.

Description

area:3d effort:high enhancement P7 source:agent

Found while merging main (#544 orbit, #545 Sinker Side Burn) into PR #1157 (#546, electrode wear compensation in Z).

What happens now: a Sinker Side Burn that states a measured electrode wear (wear_lost / wear_over) or a layer step is refused by name at every door - create, edit, paste, change-kind, the project reader and the generator: "electrode wear compensation is not supported on a Sinker Side Burn yet - clear the wear rate" (and "burning in layers is not supported on a Sinker Side Burn yet - clear the layer step"). A condition's stated wear is not applied to a side burn: its plunge stays uncompensated, as on main (shallower, never deeper).

What is wanted: the side burn's plunge compensated in Z the way the Sinker Burn's is (motion::sinker_wear: each layer's tip (top-d)+gap-rate*d, every move re-checked against the deepest compensated tip), with the lateral move made at the worn tip, and the side's allowance law (undersize less spark gap) judged with the worn electrode's side wear in mind. Open design point: whether lateral (side) wear of the electrode changes the allowance, or only its end wear is compensated.

Safety floor: changes posted Z and a gouge law, so effort:high at least.

Done means: a Side Burn with a stated wear rate generates a compensated plunge and lateral move, no move goes below the deepest compensated tip, the stock sim finds the finished cavity clean, the by-name refusal is removed, and tests pin each of these (motion + app sinker_side).

Part of #290. Follows #546 (PR #1157) and #545.

Label note: there is no area:edm label; area:3d follows #544/#545/#546.

Dominant language
Rust
Stars
8
Forks
11
Avg merge
6h 39m
Merged PRs (30d)
603

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NeoTech/Camcraft

All issues in NeoTech/Camcraft

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.