Modprobe config file on SLES does not use --allow-unsupported-modules option

Open Beginner friendly
#349 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c, linux

Research direction

Read the MODPROBE macro near line 11 of packages/gdrcopy.spec, then inspect the modprobe configuration generated around lines 203–212. Check how the SLES-specific option is represented and run the relevant packaging or install checks. Done means the generated SLES configuration includes --allow-unsupported-modules so the module can load on reboot.

Written by the indexing model from the issue text.

Description

The .spec file defines this MODPROBE macro to work on systems like SLES that require it for out of tree modules:

https://github.com/NVIDIA/gdrcopy/blob/fcec3ce0bb40a97a6cc45dd4afeec4bccb509712/packages/gdrcopy.spec#L11

The modprobe config file created on SLES still hard codes /sbin/modprobe, causing the module load to fail on reboot

https://github.com/NVIDIA/gdrcopy/blob/fcec3ce0bb40a97a6cc45dd4afeec4bccb509712/packages/gdrcopy.spec#L203-L212

The modprobe config file should include --allow-unsupported-modules on SLES.

Dominant language
C
Stars
1.4k
Forks
198
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NVIDIA/gdrcopy

All issues in NVIDIA/gdrcopy

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.