[API] `--mode mp4` should require a declared stop
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Look at the runner's command-line argument parsing and validation logic, likely in a file like cli/runner.py or flashdreams/run_v2.py. The --mode mp4 handling and the existing --timeout flag are entry points. Understand how the runner currently determines when to stop encoding. The change involves adding new flags (--total-model-steps, --total-ui-steps) and enforcing that at least one bound is provided for MP4 mode. Check the linked PR #652 to see the recent changes around app lifetime and UI overlays.
Written by the indexing model from the issue text.
Description
Summary
--mode mp4 writes a file. Nobody is sitting there to close a window, and this mode never sends a close event, so the run has to stop itself. Native-window and WebRTC can wait until the client closes.
If the app never finishes (is_finished stays false; no app-owned stop), an MP4 run has no reason to stop. It encodes until kill. Every app then has to invent its own file-length story, or people paper over it with --timeout.
This is chassis CLI, not a Cam2V special case. App flags after -- stay on the app. The runner does not parse them and does not special-case slugs.
Not this issue. #640 / #652 is Cam2V --mode mp4 with UI overlay that keeps encoding after the app declared lifetime (e.g. --total-blocks) is already done. Without the overlay, encoding already stopped. That hang is that PR.
Links
- Dominant language
- Python
- Stars
- 522
- Forks
- 66
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 46
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NVIDIA/flashdreams
-
Priority-P2 Type-clean up
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
NVIDIA/flashdreams#590 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
NVIDIA/flashdreams#739 ·
Maintainers usually reply within 1 day
-
Remove aiortc, mp4, and ffmpegPossibly taken @ArielG-NV claimed this 4 days ago. Open
NVIDIA/flashdreams#738 · 1 assignee ·
Maintainers usually reply within 1 day
-
Add AV1 Backed `OutputSink`Possibly taken @ArielG-NV claimed this 4 days ago. OpenType-enhancement
NVIDIA/flashdreams#737 · 1 assignee ·
Maintainers usually reply within 1 day
-
Type-clean up
Difficulty 4/5 3-5 days Newbie friendliness 35/100
NVIDIA/flashdreams#715 ·
Maintainers usually reply within 1 day
All issues in NVIDIA/flashdreams
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
pydot/pydot#601 · 4 comments ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
letsencrypt/cp-cps#361 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
CI: startup_failure because callers grant fewer permissions than ledger-app-workflows@v1 declaresPossibly taken @maykonmichel claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
LedgerHQ/app-boilerplate-rust#227 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
linuxmint/mintupdate#1107 ·