Code on exercise slide inconsistent with notebook

Open
#85 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
jupyter-notebook
Domain
documentation

Research direction

Compare slide 112 of ACH-01.pdf with the 01.05.03-Exercise-Segmented-Mean notebook, focusing on the inline mean_functor definition and its width handling. Update the slide so its code matches the exercise, then verify that the corrected PDF content is consistent with the notebook.

Written by the indexing model from the issue text.

Description

The code on slide 112 of ACH-01.pdf is inconsistent with the code in the actual exercise (01.05.03-Exercise-Segmented-Mean).

On the slide the mean_functor class is defined inline inside the function. Therefore it is missing the member variable width and does not pass the local variable width to the constructor of the functor. These differences are confusing to students.

Dominant language
Jupyter Notebook
Stars
2.1k
Forks
358
Avg merge
3d 19h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NVIDIA/accelerated-computing-hub

All issues in NVIDIA/accelerated-computing-hub

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.