Title: Vulkan: VK_FORMAT_R8_UNORM missing in Vulkan::getFormat
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
Research direction
Start by reading vulkan.cpp and compare Vulkan::getFormat with getNativeFormat, which the issue says already handles VK_FORMAT_R8_UNORM. Check the format mappings for R16G16_UINT and R16G16_SINT as well. Confirm the relevant formats are returned correctly and that the undefined-format log no longer occurs for the reported R8_UNORM case.
Written by the indexing model from the issue text.
Description
Hi,
With latest sdk I got sl.log to be flooded with "Cannot have undefined format", 4 times per DLSS evaluation.
It seems to happen because I tag kBufferTypeBiasCurrentColorHint with an R8_UNORM texture, and Vulkan::getFormat in vulkan.cpp has no case for VK_FORMAT_R8_UNORM (getNativeFormat has it).
I think this should fix it:
case VK_FORMAT_R8_UNORM: format = eFormatR8UN; break;
R16G16_UINT and R16G16_SINT seem to be missing from getFormat too.
Thanks!
- Dominant language
- C
- Stars
- 1.4k
- Forks
- 174
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NVIDIA-RTX/Streamline
-
sl.log folder makes it hard to integrate, as many developer has *.log in the exclude filter for git/p4.Possibly taken @Dragon31337 claimed this 72 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
NVIDIA-RTX/Streamline#121 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
NVIDIA-RTX/Streamline#120 ·
-
C++23 issueOpenbug triaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NVIDIA-RTX/Streamline#111 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
NVIDIA-RTX/Streamline#136 · 1 comment · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
NVIDIA-RTX/Streamline#134 ·
All issues in NVIDIA-RTX/Streamline
Similar issues
-
ecs_ptr_from_json does not free the buffer of a string longer than 256 bytes on two error pathsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SanderMertens/flecs#2444 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Cisco-Talos/clamav#1941 ·
Maintainers usually reply within 2 days
-
Status: Opened
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
espressif/esp-eth-drivers#201 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
libsdl-org/SDL#16788 ·
Maintainers usually reply within 1 day