Non-Uniform Scale Transofrmation Support

Open
#3 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale

Research direction

Start in gbuffer_vs.hlsl at the normal and tangent transformations shown in the issue. Update the transformation to use transpose(inverse(instanceMatrix)) for non-uniform scaling, then verify the shader behavior with a non-uniform instanceMatrix and confirm the transformed normals and tangents are correct.

Written by the indexing model from the issue text.

Description

in gbuffer_vs.hlsl:
o_vtx.normal = mul(instanceMatrix, float4(i_vtx.normal, 0)).xyz;
o_vtx.tangent.xyz = mul(instanceMatrix, float4(i_vtx.tangent.xyz, 0)).xyz;
o_vtx.tangent.w = i_vtx.tangent.w;

need to use transpose(inverse(instanceMatrix)).

Dominant language
C++
Stars
481
Forks
93
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NVIDIA-RTX/Donut

All issues in NVIDIA-RTX/Donut

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.