zoom_sequence option not supported via URL parameter
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start in src/js/timeline/Timeline.js around the constructor option handling cited in the issue, then trace zoom_sequence into the Zoom function. Check the options documentation and embed-page URL handling to reproduce the failure. Done means a URL-provided zoom_sequence no longer breaks zoom, either by safe conversion or clear rejection without eval.
Written by the indexing model from the issue text.
Description
Via ZenDesk, a user reported that a timeline URL including the fragment &zoom_sequence=[0.5,1,2,3,5,8,13,21,34,55,89] did not achieve the desired effect, and, in fact, broke the zoom function.
This is one of the exceptions noted on the options documentation page, "you can pass most of these as URL parameters" (emphasis added).
At its heart is that TimelineJS accepts most options passed in the constructor as strings (see this code). There's special handling for default_bg_color, to see if it is passed as a string.
At a minimum, the Zoom function should not fail if a String value is provided for this option. It could be rejected, or, if done safely, possibly converted into a true array. (safely means no eval of course).
Of course, this option can be passed as an array if a timeline is initialized via javascript code; the issue only arises when it is passed as a URL parameter to the embed page.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NUKnightLab/TimelineJS3
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
NUKnightLab/TimelineJS3#797 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
NUKnightLab/TimelineJS3#617 ·
-
Bug CSS
Difficulty 1/5 Under an hour Newbie friendliness 62/100
NUKnightLab/TimelineJS3#602 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
NUKnightLab/TimelineJS3#904 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
NUKnightLab/TimelineJS3#902 · 2 comments ·
All issues in NUKnightLab/TimelineJS3
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·