Check integrability without fktables or grids

Open
#2,348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
data

Research direction

The issue proposes checking integrability directly from the PDF instead of creating ad hoc grids or using fktables. Start by tracing the existing integrability check and the postfit path to see where grids or fktables are involved. Done means the PDF is checked directly and the unnecessary grid or fktable work is removed; the issue names no files or tests.

Written by the indexing model from the issue text.

Description

enhancement

We can check integrability directly looking at the PDF instead of creating ad-hoc grids. As @giacomomagni and @evagroenendijk just found out, the amount of things thst can go wrong is very high and there is no benefit.

(actually, for postfit we are not using the fktables at all)

Dominant language
Python
Stars
44
Forks
15
Avg merge
8d 12h
Merged PRs (30d)
7

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NNPDF/nnpdf

All issues in NNPDF/nnpdf

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.