NLogRequestLoggingModule - Introduce ShouldLogRequest
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- backend, observability-sre
Research direction
Compare the existing ShouldLogRequest behavior on NLogRequestLoggingMiddleware with NLogRequestLoggingModule, then review the module's request and exception logging entry points. Clarify whether the requested change is only the predicate API or also reduced exception logging for informational levels and canceled ASP.NET Core requests. Done means the agreed behavior is consistently available for the module.
Written by the indexing model from the issue text.
Description
Like ShouldLogRequest is available for NLogRequestLoggingMiddleware, so one can downgrade LogLevel, then it should always be available for NLogRequestLoggingModule.
Maybe consider changing the logging so when LogLevel <= Info, then skip logging the exception. But just perform logging of the Exception.Type and Exception.Message (Ex. Input-Validation-Errors).
This could also be useful for ASP.NET Core, where HTTP 499 Client Closed Request together with TaskCanceledException should not be seen as "Error" (catch (OperationCanceledException) when (httpContext.RequestAborted.IsCancellationRequested))
- Dominant language
- C#
- Stars
- 327
- Forks
- 161
- Avg merge
- 1d 41m
- Merged PRs (30d)
- 7
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NLog/NLog.Web
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
ASP.NET Core docs
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
ASP.NET Core feature up-for-grabs
Difficulty 5/5 Over a week Newbie friendliness 20/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NimblePros/eShopOnWeb#333 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Natvs/Nt.Automaton#33 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 2/5 Half a day Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
a-corriger documentation
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
christian-raj/S-Aloha#312 ·