CodeQL: Make final fields static in Crypto Service
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
Research direction
Start by reviewing the CodeQL findings in DecryptService.java, EncryptService.java, IcvCreateService.java, and IcvVerifyService.java, then inspect the commented-out blocks in DecryptServiceResponse.java and IcvCreateServiceResponse.java. Confirm each listed final field and commented block, make the requested maintainability cleanup, and run the project's Java build or tests to verify completion.
Written by the indexing model from the issue text.
Description
Maintainability issue flagge dby CodeQL.
Make final field static.
kmc-crypto-service/.../jpl/ammos/kmc/crypto/service/DecryptService.java
kmc-crypto-service/.../jpl/ammos/kmc/crypto/service/EncryptService.java
kmc-crypto-service/.../jpl/ammos/kmc/crypto/service/IcvCreateService.java
kmc-crypto-service/.../jpl/ammos/kmc/crypto/service/IcvVerifyService.java
This block of commented-out lines of code should be removed.
kmc-crypto-service/.../jpl/ammos/kmc/crypto/model/DecryptServiceResponse.java
kmc-crypto-service/.../jpl/ammos/kmc/crypto/model/IcvCreateServiceResponse.java
- Dominant language
- Java
- Stars
- 6
- Forks
- 5
- Avg merge
- 17h 30m
- Merged PRs (30d)
- 9
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NASA-AMMOS/DCS
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
NASA-AMMOS/DCS#66 ·
Maintainers usually reply within 1 day
-
CodeQL: Disable external XML parsing in kmip-clientMay be free again @kamtso-jpl claimed this 322 days ago, and no pull request is open. Opencrit-3 security
NASA-AMMOS/DCS#59 · 1 assignee ·
Maintainers usually reply within 1 day
-
CodeQL: Update KMIP Client to use TLSV1.2May be free again @kamtso-jpl claimed this 330 days ago, and no pull request is open. Opencrit-3 security
NASA-AMMOS/DCS#55 · 1 assignee ·
Maintainers usually reply within 1 day
-
CodeQL: Potential overflow in test codeMay be free again @kamtso-jpl claimed this 330 days ago, and no pull request is open. Opencrit-4 security
NASA-AMMOS/DCS#53 · 1 assignee ·
Maintainers usually reply within 1 day
-
crit-3 security
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
NASA-AMMOS/DCS#49 ·
Maintainers usually reply within 1 day
Similar issues
-
area:core bug priority:p2
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aomarai/minecraft-mcp#247 ·
Maintainers usually reply within 1 day
-
help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
antonyrag/ragleap-core#1062 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Vakore/ZappierGames#232 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
constellation-app/constellation#2588 ·