Add unit testing of Sample PP config fragments
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 40/100
Research direction
Start with the #364 fix the issue builds on, and find the leaf-value functions that take json_t *value arguments in the sample config fragment code. The work is to move them into their own compilation unit behind a private header, keeping Jansson out of the public interface. Done means those functions can be unit tested directly, with new tests covering config fragment variations, and the existing build and tests still pass. The issue does not list which functions to move, so confirm the scope with maintainers first.
Written by the indexing model from the issue text.
Description
Following on to the #364 fix, these leaf-value functions as well as others should be refactored into a separate compilation unit with a private header and able to be unit tested. The functions all take json_t *value arguments, so cannot be part of the public interface because Jansson is not a public dependency.
This will enable more exhaustive unit testing of config fragment variations without needing the entire config file to test.
- Dominant language
- C
- Stars
- 16
- Forks
- 9
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NASA-AMMOS/BSL
-
BIB validator rejects BIB targeting the primary block (block 0), deleting the bundle at sourcePossibly taken @jeronstone claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NASA-AMMOS/BSL#373 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Policy query leaks host primary block (BSL_PrimaryBlock_deinit skipped) on two early-exit pathsPossibly taken @jeronstone claimed this 9 days ago. Openbug CRIT-3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NASA-AMMOS/BSL#355 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
CMake warnings about deprecated behaviorsPossibly taken @BrianSipos claimed this 8 days ago. Opensustainment
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NASA-AMMOS/BSL#282 · 1 assignee ·
Maintainers usually reply within 1 day
-
bug CRIT-3
Difficulty 3/5 Half a day Newbie friendliness 35/100
NASA-AMMOS/BSL#371 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 38/100
NASA-AMMOS/BSL#370 ·
Maintainers usually reply within 1 day
Similar issues
-
TLS: a stale OpenSSL error makes non-blocking reads fail with "Resource temporarily unavailable"Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
bigtreetech/BIGTREETECH-TouchScreenFirmware#3056 ·
Maintainers usually reply within 1 day
-
Allow pillow 13Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
[pico][astrocade] emu/apply.sh edits src/mame/midway/astrohome.cpp, which current MAME has in bally/Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
FujiNetWIFI/fujinet-firmware#2120 ·
Maintainers usually reply within 1 day