Validate fiat code membership against the daemon's advertised supported_currencies
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
Research direction
Start by reading the create-order preflight added in PR #304 and rust/src/api/types.rs, which exposes supported_currencies from the Kind 38385 instance event. Trace how that advertised list reaches the client and where the preflight checks fiat codes. Done when a syntactically valid but unsupported code such as XYZ is rejected using the daemon's list.
Written by the indexing model from the issue text.
Description
#304 added a syntactic create-order preflight for fiat codes (ISO 4217 shape: three uppercase ASCII letters). A well-formed but unsupported code such as XYZ still passes the client check and is only rejected by the daemon.
Full membership validation should check against the daemon's advertised supported_currencies (rust/src/api/types.rs, sourced from the Kind 38385 instance event) rather than a Rust copy of assets/data/fiat.json the daemon's list is authoritative and cannot drift from the bundled asset. This closes the remaining half of #175.
Context: PR #304.
- Dominant language
- Dart
- Stars
- 11
- Forks
- 9
- Avg merge
- 17h 18m
- Merged PRs (30d)
- 195
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MostroP2P/app
-
feat(reputation): show the source of an attestation before importing itPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
MostroP2P/app#881 · 1 comment ·
Maintainers usually reply within 1 day
-
area: rust-core bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area: ui
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
fable-compiler/Fable#5157 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bannzai/medicalarm#430 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
fossasia/badgemagic-app#2016 ·
Maintainers usually reply within 1 day
-
area-vm
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
dart-lang/sdk#64727 · 1 comment ·
Maintainers usually reply within 4 days
-
bug P3 ux
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
QueryaHub/Querya-Desktop#1837 ·
Maintainers usually reply within 1 day