Some variables are not condensed to invocations.

Open

#78 opened on Jun 16, 2020 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 42/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: java
Domain: compilers

Research direction

Start by reproducing the ScaffoldingBlock static initializer shown in the issue and inspect the decompiler path that handles stack variables and field initializers. Check the bytecode-order validation mentioned in the update; done means the variables are condensed into invocation arguments without changing initializer order.

Written by the indexing model from the issue text.

Description

1.16-pre1 ScaffoldingBlock's static class doesn't condense stack variables into the argument list.
This causes the field initializes to not be inlined.

      VoxelShape voxelshape = Block.func_208617_a(0.0D, 14.0D, 0.0D, 16.0D, 16.0D, 16.0D);
      VoxelShape voxelshape1 = Block.func_208617_a(0.0D, 0.0D, 0.0D, 2.0D, 16.0D, 2.0D);
      VoxelShape voxelshape2 = Block.func_208617_a(14.0D, 0.0D, 0.0D, 16.0D, 16.0D, 2.0D);
      VoxelShape voxelshape3 = Block.func_208617_a(0.0D, 0.0D, 14.0D, 2.0D, 16.0D, 16.0D);
      VoxelShape voxelshape4 = Block.func_208617_a(14.0D, 0.0D, 14.0D, 16.0D, 16.0D, 16.0D);
      field_220121_d = VoxelShapes.func_216384_a(voxelshape, voxelshape1, voxelshape2, voxelshape3, voxelshape4);
      VoxelShape voxelshape5 = Block.func_208617_a(0.0D, 0.0D, 0.0D, 2.0D, 2.0D, 16.0D);
      VoxelShape voxelshape6 = Block.func_208617_a(14.0D, 0.0D, 0.0D, 16.0D, 2.0D, 16.0D);
      VoxelShape voxelshape7 = Block.func_208617_a(0.0D, 0.0D, 14.0D, 16.0D, 2.0D, 16.0D);
      VoxelShape voxelshape8 = Block.func_208617_a(0.0D, 0.0D, 0.0D, 16.0D, 2.0D, 2.0D);
      field_220122_e = VoxelShapes.func_216384_a(field_220123_f, field_220121_d, voxelshape6, voxelshape5, voxelshape8, voxelshape7);
   }

Edit: Looked into it more and it is correct to not move the initalizers up, as it would change the order from the bytecode. So when we fix this we also need to fix that check...

Dominant language: No language data
Stars: 110
Forks: 49
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Unicode string escape silently accepts any number of repeated 'u' characters, not just one Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

objectionary/eo#8923 · Opened Sep 23, 2026
`quote_keys` quotes private class member names, producing invalid output Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

terser/terser#1743 · Opened Sep 23, 2026
Coarray integration tests carry no LABELS, so run_tests.py silently skips them under every backend Open

coarray

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

lfortran/lfortran#13405 · Opened Sep 23, 2026
Float != answers false for NaN: arith.cmpf one where une belongs Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

vx-lang/Vx#716 · Opened Sep 23, 2026
internal.h中，漏掉了1个定义。 Open

Difficulty 1/5 Under an hour Newbie friendliness 95/100

microsoft/mimalloc#1414 · 1 reaction · Opened Sep 23, 2026

More Compilers issues