Improper for loop promotion from while
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 30/100
Research direction
Start with RealmsSelectWorldTemplate.func_224497_a and compare the generated for-loop form with the while-loop structure shown in the issue. Trace how the decompiler handles the loop initializer, condition, update expression, and Either variable; done means this case is emitted as the intended while loop without regressing related loop transformations.
Written by the indexing model from the issue text.
Description
1.16-pre1 RealmsSelectWorldTemplate.func_224497_a
WorldTemplatePaginatedList worldtemplatepaginatedlist = p_224497_1_;
Either<WorldTemplatePaginatedList, String> either;
for(RealmsClient realmsclient = RealmsClient.func_224911_a(); worldtemplatepaginatedlist != null; worldtemplatepaginatedlist = RealmsSelectWorldTemplateScreen.this.field_230706_i_.func_213169_a(() -> {
if (either.right().isPresent()) {
...
} else {
...
}
}).join()) {
either = RealmsSelectWorldTemplateScreen.this.func_224509_a(worldtemplatepaginatedlist, realmsclient);
}
WorldTemplatePaginatedList worldtemplatepaginatedlist = p_224497_1_;
RealmsClient realmsclient = RealmsClient.func_224911_a();
while (worldtemplatepaginatedlist != null) {
Either<WorldTemplatePaginatedList, String> either = RealmsSelectWorldTemplateScreen.this.func_224509_a(worldtemplatepaginatedlist, realmsclient);
worldtemplatepaginatedlist = RealmsSelectWorldTemplateScreen.this.field_230706_i_.func_213169_a(() -> {
if (either.right().isPresent()) {
...
} else {
...
}
};
}
- Dominant language
- No language data
- Stars
- 110
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MinecraftForge/ForgeFlower
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
MinecraftForge/ForgeFlower#131 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MinecraftForge/ForgeFlower#86 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MinecraftForge/ForgeFlower#85 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
All issues in MinecraftForge/ForgeFlower
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sveltejs/acorn-typescript#150 ·
-
area:stdlib found-by:code-review kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1338 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
microsoft/TypeScript#64453 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day