TODO: Reevaluate include-entire-classpath

Open
#59 4 comments 0 reactions 0 assignees View on GitHub

@zml2008 is already working on this.

Since May 8, 2022.

  • #118 by @zml2008 — open

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Domain
compilers

Research direction

Locate the include-entire-classpath option and inspect the open pull request #118 before starting, since related work is already underway. Evaluate the current eager classpath metadata behavior, with attention to memory cost, generic and type information, and the stated threading and race concerns; done requires a decided and validated replacement approach.

Written by the indexing model from the issue text.

Description

The point of this is to make generics and type information better.
However it has a major memory cost as it reads ALL the classes in the classpath and parses out their metadata.

A better idea would be to make the metadata system lazy, but that runs into threading and race issues.

So, this is the TODO to look at it... eventually..

Dominant language
No language data
Stars
110
Forks
49
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MinecraftForge/ForgeFlower

All issues in MinecraftForge/ForgeFlower

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.