Some enchanced for loops are not enhanced.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start at NetHandlerPlayClient.func_191980_a in the decompiler output shown in the issue and compare the REMOVE and INIT iterator loops with the existing enhanced loops. Trace the corresponding decompiler handling for these loops, then verify that eligible iterator-based loops are emitted consistently without changing the method's behavior.
Written by the indexing model from the issue text.
Description
See 1.13, NetHandlerPlayClient.func_191980_a
label57:
switch(spacketrecipebook$state) {
case REMOVE:
Iterator iterator1 = p_191980_1_.func_192595_a().iterator();
while(true) {
if (!iterator1.hasNext()) {
break label57;
}
ResourceLocation resourcelocation3 = (ResourceLocation)iterator1.next();
IRecipe irecipe3 = this.field_199528_o.func_199517_a(resourcelocation3);
if (irecipe3 != null) {
recipebookclient.func_193831_b(irecipe3);
}
}
case INIT:
for(ResourceLocation resourcelocation1 : p_191980_1_.func_192595_a()) {
IRecipe irecipe1 = this.field_199528_o.func_199517_a(resourcelocation1);
if (irecipe1 != null) {
recipebookclient.func_194073_a(irecipe1);
}
}
Iterator iterator = p_191980_1_.func_193644_b().iterator();
while(true) {
if (!iterator.hasNext()) {
break label57;
}
ResourceLocation resourcelocation2 = (ResourceLocation)iterator.next();
IRecipe irecipe2 = this.field_199528_o.func_199517_a(resourcelocation2);
if (irecipe2 != null) {
recipebookclient.func_193825_e(irecipe2);
}
}
case ADD:
for(ResourceLocation resourcelocation : p_191980_1_.func_192595_a()) {
IRecipe irecipe = this.field_199528_o.func_199517_a(resourcelocation);
if (irecipe != null) {
recipebookclient.func_194073_a(irecipe);
recipebookclient.func_193825_e(irecipe);
RecipeToast.func_193665_a(this.field_147299_f.func_193033_an(), irecipe);
}
}
}
- Dominant language
- No language data
- Stars
- 110
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MinecraftForge/ForgeFlower
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
MinecraftForge/ForgeFlower#131 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MinecraftForge/ForgeFlower#86 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MinecraftForge/ForgeFlower#85 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
All issues in MinecraftForge/ForgeFlower
Similar issues
-
compiler/runtime
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
objectionary/eo#8869 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
EricSpencer00/Resilient#4824 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/jeo-maven-plugin#1758 ·
-
generics
Difficulty 2/5 1-3 hours Newbie friendliness 82/100