Fix `messenger` type naming in BaseControllerV2

Open Beginner friendly
#4,491 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
backend

Research direction

Open BaseControllerV2.ts and locate the type declaration and its references. Rename the type from messenger to Messenger consistently, then verify that no old references remain and the TypeScript checks pass.

Written by the indexing model from the issue text.

Description

team-assets team-wallet-framework wf-controller-tech-debt

In the BaseControllerV2.ts, the messenger type has been defined starting with a small letter. The type needs to start with a capital. To fix this, messenger has to be renamed to Messenger.
Screenshot 2024-07-01 at 12.08.34.png

Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/core

All issues in MetaMask/core

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.