@metamask/foundryup "Invalid version" should not check version starts with 'v'

Open Beginner friendly
#6,245 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
cli, tooling

Research direction

Start with packages/foundryup/src/options.ts, especially the validation around the --version option, and reproduce the issue with yarn mm-foundryup install --version=stable. Check the existing version rules against the option description and Foundry tags; done means stable and nightly are accepted without breaking valid version handling.

Written by the indexing model from the issue text.

Description

E.g. when running yarn mm-foundryup install --version=stable

It checks if it is a valid version string starting with 'v'.
However, options description of the --version: Specify the version (see: https://github.com/foundry-rs/foundry/tags) [default: "nightly"]

Both nightly and stable are valid tags. This logic should be removed or changed to allow stable or nightly tag/version.

https://github.com/MetaMask/core/blob/afd5e91404cf6da2a28ed87e7ec3652f4b7aa08b/packages/foundryup/src/options.ts#L17-L25

Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/core

All issues in MetaMask/core

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.