Delete attached photos when a feature is deleted
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 65/100
Research direction
No files or tests are named. Start by tracing feature deletion, discard handling, and composition versus association child handling, then verify each acceptance criterion, including nested children, orphaned photos, and the discard confirmation text.
Written by the indexing model from the issue text.
Description
Current situation
When a feature is deleted, its attached photos stay on the device and in the project. This leaves unused files behind, and with the composition relation supported (https://github.com/MerginMaps/mobile/issues/2315) more features will be deleted automatically, so more orphaned photos could pile up.
Proposed solution
When a feature is deleted, delete its attached photos as well. This also applies to child features deleted through a composition relation (for example, if a parent feature is deleted, then its children should be deleted as well)
Acceptance criteria
- Deleting a feature deletes its attached photo(s)
- Deleting a parent with composition children deletes the photo(s) of all deleted child features (including nested ones)
- If child features are created while adding a parent, and the parent is discarded without saving, the photos of those child features are deleted too
- Deleting a parent with association children does not delete the children's photos (and neither the children, check acceptance criteria of (https://github.com/MerginMaps/mobile/issues/2315)
- when discarding a parent feature with composition children, the delete confirmation text mentioned that the attached photos will also be deleted
Related to: https://github.com/MerginMaps/mobile/issues/2315
- Dominant language
- C++
- Stars
- 388
- Forks
- 87
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 16
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MerginMaps/mobile
-
bug ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
MerginMaps/mobile#4669 ·
Maintainers usually reply within 2 days
-
bug Good first issue ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MerginMaps/mobile#4665 ·
Maintainers usually reply within 2 days
-
bug ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
MerginMaps/mobile#4647 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
MerginMaps/mobile#4726 ·
Maintainers usually reply within 2 days
-
[iOS] GPS info dialog shows N/A for visible and used satellites (Internal GPS and External Mock)Openbug GPS iOS 🍎
Difficulty 3/5 1-2 days Newbie friendliness 56/100
MerginMaps/mobile#4725 ·
Maintainers usually reply within 2 days
All issues in MerginMaps/mobile
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
microsoft/onnxruntime#33018 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
customer-reported needs-triage question
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Azure/azure-sdk-for-cpp#7435 ·
Maintainers usually reply within 1 day
-
ChromieCraft Generic Confirmed World Event
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
azerothcore/azerothcore-wotlk#27882 ·
Maintainers usually reply within 1 day
-
MacOS build failureOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aristocratos/btop#1874 ·
Maintainers usually reply within 1 day