A lot of if-else in `format_ae_listing()`
@fukuhiro2023 is already working on this.
Since Sep 16, 2026.
Assessment
This issue has not been assessed yet.
Description
We have a lot of if statements in the format_ae_listing() function handling various tasks (see https://github.com/Merck/forestly/blob/main/R/ae_listing.R#L336-L508), including simple ones like converting to title case or relabeling columns. It also includes some calculations, as seen in lines 465-506.
I am wondering if these if-else statements are redundant, considering:
- Variable names might differ from one study to another.
- They may slow down execution time.
- Should we just display exactly what is already in the dataset?
- Dominant language
- R
- Stars
- 22
- Forks
- 6
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 10
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Merck/forestly
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
briandconnelly/airnow#9 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
OHDSI/CohortConstructor#774 ·
-
pre-review R TeX Track: 5 (DSAIS)
Difficulty 1/5 Under an hour Newbie friendliness 60/100
openjournals/joss-reviews#11330 · 7 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100